Merged
Conversation
eps1lon
commented
Jan 24, 2020
| expect(events).toEqual( | ||
| expect.arrayContaining([expect.objectContaining({isChanged: true})]), | ||
| ); | ||
| expect(events).toHaveLength(0); |
Author
There was a problem hiding this comment.
@trueadm The tests in this file look suspicious. As far as I can tell they changed due to JSDOM supporting passive events. At least I noticed that it bails out at https://github.com/eps1lon/react/blob/118d91b1eced121a38cc7da988194f713ca6248a/packages/react-interactions/events/src/dom/Drag.js#L169. Don't know if this was the case before though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c7ebfe1: matches chrome now: https://codesandbox.io/s/resets-value-of-datetime-input-to-fix-bugs-in-ios-safari-1ppwh
ce21316: unknown
db63f6d: example of browser behavior for one of the affected tests: https://codesandbox.io/s/beautiful-cdn-ugn8f
225c19b: was already marked as JSDOM workaround
1a7870f: JSDOm now supports passive events. Though this removes a significant amount of "useful" assertions. Core member would need to look
010a0d1: "Fixed focusing an already-focused element to correctly do nothing, instead of firing additional focus events." -- jsdom 15.2.1
118d91b: "Add basic support for CSS custom properties" -- cssstyle 2.2.0; waiting for jsdom/cssstyle#112 resolution